Comments on: Why sfContext::getInstance() Is Bad

By: Bernhard

Bernhard — Fri, 05 Mar 2010 15:08:09 +0000

@Interested: Just inject the I18N instance into the form. I’m doing that too.

$form = new myForm($i18n, …);

And concerning the helpers… it’s probably better not to use them at all and rely on the underlying implementation. format_date(), f.i., is just a wrapper for sfNumberFormat. So use sfNumberFormat instead.

@John: What do you mean? In the form? Inject them.

By: John

John — Fri, 05 Mar 2010 15:00:08 +0000

How is it possible to get “multiple sfUser instances” ?

By: Interested

Interested — Fri, 05 Mar 2010 14:57:45 +0000

And how about I18n or other helpers loading in Form, or Model class (sfContext::getInstance()->getConfiguration()->loadHelpers(’I18N’);)

By: Christopher Shennan

Christopher Shennan — Tue, 16 Feb 2010 15:57:19 +0000

I’ve usually come across this when using sfForm and I get around this by using the constructor injector mentioned above but pass the object I want as an option i.e.

$form = new myForm(array(), array(’sf_guard_user’ => $user));

Passing it in this manner allows me to access it in the form class via $this->options['sf_guard_user'];

By: jwesker

jwesker — Thu, 04 Feb 2010 18:27:27 +0000

@gpilotino, Yeah, how is sfContext::getInstace() avoidable from the generator, and also from the form classes? is it possible to inject dependency on the forms too?

By: David Clark

David Clark — Thu, 03 Dec 2009 14:23:02 +0000

THANKS ;
I have been struggling with dependency injection forever, this really helps!

By: gpilotino

gpilotino — Mon, 09 Nov 2009 15:35:26 +0000

I can see another situation where you cannot avoid using sfContext::getInstance(): the admin generator.
(ie. how can you have a table_method / peer_method filtered on user credentials without accessing context from the Model ?)

By: David

David — Tue, 29 Sep 2009 15:13:22 +0000

There’s one more thing to add here: if you REALLY need a context in an sfTask (symfony command line task), you can use the following:

protected function execute($arguments = array(), $options = array())
{
$databaseManager = new sfDatabaseManager($this->configuration);
sfContext::createInstance($this->configuration);

// your code goes here
}

By: Dextro

Dextro — Thu, 27 Aug 2009 11:20:30 +0000

Perfect explanation. Thx!

By: Bernhard

Bernhard — Thu, 20 Aug 2009 07:57:31 +0000

@Peter: Thank you, fixed